Conversation
…ckpoint restore - Fix checkpoint_tokens_skipped = cp.tokens.len() instead of cp.position to prevent overshooting verified prefix when matching checkpoints - Update state.previous_tokens on checkpoint restore to keep periodic checkpoint saves from storing stale token data
- Change cache_status() selection from highest priority to longest matching prefix, using priority only as tiebreaker for equal lengths. This means Turn 2 reuses the full Turn 1 checkpoint (including assistant response) instead of falling back to an older ToolCall checkpoint, avoiding unnecessary reprocessing. - Add tests: prefers_longer_prefix_over_higher_priority, same_length_uses_priority_tiebreaker - Remove dead periodic_interval/last_periodic_position fields and should_save_periodic method (periodic saves moved out of decode loop)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to prevent overshooting verified prefix when matching checkpoints
checkpoint saves from storing stale token data
matching prefix, using priority only as tiebreaker for equal lengths.
This means Turn 2 reuses the full Turn 1 checkpoint (including
assistant response) instead of falling back to an older ToolCall
checkpoint, avoiding unnecessary reprocessing.
same_length_uses_priority_tiebreaker
should_save_periodic method (periodic saves moved out of decode loop)